libp2phttp.Host implements RoundTripper #2840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
approved these changes
Jun 19, 2024
|
|
||
| testCases := []string{ | ||
| // Version that has an http-path. Will uncomment when we get the http-path changes in go-multiaddr | ||
| // "multiaddr:" + serverHost.Addrs()[0].String() + "/http-path/hello", |
Comment on lines
+410
to
+412
| // if true, we won't add the server's addresses to the peerstore. This | ||
| // should only be set when creating the struct. | ||
| skipAddAddrs bool |
There was a problem hiding this comment.
Can you elaborate on why we need this?
There was a problem hiding this comment.
It really doesn't matter, but it saves us the synchronization overhead of the addrsAdded sync.Once call.
Comment on lines
+663
to
+664
| if parsed.sni != parsed.host { | ||
| // We have a different host and SNI (e.g. using an IP address but specifying a SNI) |
There was a problem hiding this comment.
Does this work with /dns addrs?
Do we need something like: https://github.com/libp2p/go-libp2p/blob/master/p2p/transport/websocket/websocket.go#L123 here?
There was a problem hiding this comment.
Yes /dns works. Roundtripper handles this implicitly. Fails if the server doesn't support the SNI. Example: /dns/example.com/tls/sni/example.net/httpworks, but /dns/example.net/tls/sni/notexample.com/http fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After working on the js-libp2p API for libp2p+HTTP, I realized it's quite natural to make an HTTP request given a multiaddr URI (who would've guessed?).
This change makes using the HTTP client with libp2p easier and more natural. Instead of having to create a specialized roundtripper for each server, you can now have a single
http.Clientthat can make requests to multiple servers. The usage feels very familiar to the classic HTTP api. You can now do this: