implement connection gating at the top level #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 9, 2020
Closed
raulk
changed the title
raulk
approved these changes
May 15, 2020
Stebalien
reviewed
May 20, 2020
Stebalien
reviewed
May 20, 2020
| @@ -76,7 +78,7 @@ func callConstructor(c reflect.Value, args []reflect.Value) (interface{}, error) | |||
| return val, err | |||
| } | |||
|
|
|||
| type constructor func(h host.Host, u *tptu.Upgrader) interface{} | |||
| type constructor func(h host.Host, u *tptu.Upgrader, cg connmgr.ConnectionGater) interface{} | |||
There was a problem hiding this comment.
What was the motivation to change this function signature? It's not really an issue, but it's redundant with the ConnGater field of the upgrader.
There was a problem hiding this comment.
Yes, I had the same thought but given the types are internal, I thought it wouldn't harm us to rectify later. Wanna tackle that as a follow-up, @aarshkshah1992?
There was a problem hiding this comment.
I think this was an oversight. I'll create a follow up PR to get rid of this. #951 .
There was a problem hiding this comment.
Thanks! Note: this isn't a super high priority.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #872.
FilterandFilterAddressAPI in favour of theConnectionGaterAPI.Filterand by extensionFilterAddressOR theConnectionGaterbut NOT both.Filtersis adapted to aConnectionGaterby means ofFilterConnectionGaterConenctionGaterto the "reflection magic" so it is available to Transports that need it.