Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose option for setting autonat throttling #882

Merged
merged 3 commits into from Apr 13, 2020
Merged

Conversation

willscott
Copy link
Contributor

Exposes the underlying autonat options for throttling at the libp2p level.

config/config.go Outdated Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
options.go Outdated Show resolved Hide resolved
options.go Outdated Show resolved Hide resolved
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except that two booleans to control a single flag is generally a bad idea.

config/config.go Outdated
// autoNATConfig defines the AutoNAT behavior for the libp2p host.
type AutoNATConfig struct {
ForceReachabilityPublic bool
ForceReachabilityPrivate bool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just use an enum.

@Stebalien Stebalien merged commit a0f66ec into master Apr 13, 2020
@Stebalien Stebalien deleted the feat/throttleOption branch April 13, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants