New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential flakiness in TestIDService #945

Merged

Stebalien merged 1 commit into master from feat/944

May 20, 2020

Contributor

aarshkshah1992 commented May 20, 2020 •

edited

We should create the EvtPeerIdentificationCompleted subscriber before we connect to the other peer.

For #944.


          create subscriber first

ba118a4

aarshkshah1992 requested a review from Stebalien

May 20, 2020 09:41

Stebalien merged commit 3bf5baf into master

aarshkshah1992 deleted the feat/944 branch

May 21, 2020 04:12

Stebalien mentioned this pull request

Release 0.6.0 ipfs/kubo#7347

Closed

77 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment