Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize numInbound count #960

Merged
merged 6 commits into from Jun 4, 2020
Merged

optimize numInbound count #960

merged 6 commits into from Jun 4, 2020

Commits on Jun 4, 2020

  1. fix: make address observation types private 

    We don't use and/or expose these anyways. Making them private makes it easier to
reason about their state.
    @Stebalien
    Stebalien committed Jun 4, 2020
    Copy the full SHA
    a0813d7 View commit details
    Browse the repository at this point in the history

  2. fix(mocknet): set inbound/outbound on the right link

    @Stebalien
    Stebalien committed Jun 4, 2020
    Copy the full SHA
    6ca8330 View commit details
    Browse the repository at this point in the history

  3. fix: count observations with at least one inbound connection as inbound 

    We prefer addresses from inbound connections. We don't want outbound connections
to hide these perfectly good addresses.
    @Stebalien
    Stebalien committed Jun 4, 2020
    Copy the full SHA
    1dd7a8c View commit details
    Browse the repository at this point in the history

  4. test(id): fix nits

    @Stebalien
    Stebalien committed Jun 4, 2020
    Copy the full SHA
    1e4ce46 View commit details
    Browse the repository at this point in the history

  5. fix: optimize numInbound count 

    We call this _very_ frequently when computing our local addresses.
    @Stebalien
    Stebalien committed Jun 4, 2020
    Copy the full SHA
    a03403f View commit details
    Browse the repository at this point in the history

  6. fix(id): document observation struct

    @Stebalien
    Stebalien committed Jun 4, 2020
    Copy the full SHA
    5ae0888 View commit details
    Browse the repository at this point in the history