fix(nat): use the right addresses when nat port mapping #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscott
approved these changes
Jun 9, 2020
p2p/host/basic/basic_host.go
Outdated
| // Fall back on just using the primary interface. | ||
| // | ||
| // This should never happen, but we might as well have a fallback. | ||
| listenAddrs = finalAddrs |
There was a problem hiding this comment.
finalAddrs being used as a fallback is maybe not the best name.
There was a problem hiding this comment.
We ended up doing this a slightly different and more efficient way.
There was a problem hiding this comment.
Basically, it turns out we didn't need to resolve the addresses in the first place.
We switched `listenAddrs` from the _interface_ addresses to the raw addresses we were listening on. Unfortunately, we needed the resolved addresses later in the function when resolving port mappings.
Stebalien
force-pushed
the
fix/nat-port-mapping
branch
from
255b419
to
1180b6f
Compare
aschmahmann
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We switched
listenAddrsfrom the interface addresses to the raw addresses wewere listening on. Unfortunately, we needed the resolved addresses later in the
function when resolving port mappings.