This repository has been archived by the owner on May 26, 2022. It is now read-only.
describe how to use options in README #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
reviewed
Sep 29, 2021
| To use TCP transport options, pass them to the `libp2p.Transport` constructor: | ||
| ```go | ||
| h, err := libp2p.New( | ||
| libp2p.Transport(tcp.NewTCPTransport, tcp.DisableReuseport(), tcp.WithConnectionTimeout(20*time.Second)) |
There was a problem hiding this comment.
This seams like a good way to do this, but it's not currently supported. Are you planning on implementing it?
There was a problem hiding this comment.
As of libp2p/go-libp2p#1205, it is implemented. It's just not released yet
There was a problem hiding this comment.
We probably should hold this PR back until we've cut the next go-libp2p release.
Stebalien
approved these changes
Sep 29, 2021
|
@marten-seemann : can this be merged? |
|
Not yet, we haven't cut the next go-libp2p release yet. |
|
Got it. Given the release is coming soon, should we start a Relase 0.16
issue and then reference this PR in that issue so it becomes part of the
release process?
…On Sun, Oct 24, 2021 at 1:44 AM Marten Seemann ***@***.***> wrote:
Not yet, we haven't cut the next go-libp2p release yet.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#105 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAU3I2T7GWB4LGUCSWXT63UIPBNNANCNFSM5FACJS6Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.