This repository has been archived by the owner on May 26, 2022. It is now read-only.
Add install, usage & addressing info to README #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
Jul 10, 2019
| security for each connection according to the protocols supported by each party. | ||
|
|
||
| The transport upgrader also negotiates a stream multiplexing protocol to allow | ||
| many bidirectional streams to coexist on a single WebSocket connection. | ||
|
|
There was a problem hiding this comment.
It would also be nice to add a note about proxying. Many HTTP(s) proxies natively support websockets so they're a way to punch out of corporate networks.
There was a problem hiding this comment.
That's a good call. I'll add that in on the next round.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially the same update as in libp2p/go-tcp-transport#41, but for WebSockets.
I linked to the CoC and contributing gif from libp2p/community#3 and libp2p/community#4 respectively, so we should probably do those first.