Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connections cut under heavy load #15

Closed
Stebalien opened this issue Mar 13, 2020 · 0 comments · Fixed by #16
Closed

Connections cut under heavy load #15

Stebalien opened this issue Mar 13, 2020 · 0 comments · Fixed by #16

Comments

@Stebalien
Copy link
Member

Under heavy load, yamux connections fail to ping fast enough and get cut. We should just stop pinging when we're under load (because we know the peer is alive).
Stebalien added a commit that referenced this issue Mar 13, 2020
@Stebalien
fix: don't keepalive when the connection is busy
bddc294 
* It's a waste of bandwidth.
* It causes us to think the connection is dead because the other side is too
busy sending us _other_ data to respond to the ping.

fixes #15
This was referenced Mar 13, 2020
Merged
Open
@Stebalien Stebalien mentioned this issue Apr 24, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: don't keepalive when the connection is busy libp2p/go-yamux
1 participant
@Stebalien