fix: ensure that pings don't get stuck behind writes #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this was causing problems, but I'm not sure... Testing now. |
This sends pings/pongs first before processing messages. This ensures that: 1. RTT times are accurate. 2. We don't end up thinking the connection is dead because a ping keeps getting stuck behind a message. I tried lowering the max message size to 4KiB, but that broke tests due to a perf regression. Although I'm not sure how "real" that perf regression is.
Stebalien
force-pushed
the
fix/ping-latency
branch
from
465fb51
to
6c2bbc3
Compare
marten-seemann
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
Sets the max message size to 4 KiB. That should be large enough to fill up most packets.I had to revert this to get the tests passing.This ensures that: