This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
chore: update dependencies #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: uses new multiaddr, libp2p-interfaces, etc
vasco-santos
reviewed
Jul 9, 2021
| data: message, | ||
| topicIDs: [topic] | ||
| })) | ||
|
|
||
| expect(messageToEmit).to.eql(expected) | ||
| }) | ||
|
|
||
| it.skip('does not send received message back to original sender', async () => { | ||
|
|
There was a problem hiding this comment.
Yeah, just writing it. I pushed an update to see if CI was healthier with the libp2p rc, it is!
| floodsub1 = new Floodsub(peer1, defOptions) | ||
| floodsub2 = new Floodsub(peer2, defOptions) | ||
| const libp2p = { | ||
| peerId: await PeerId.create(), |
There was a problem hiding this comment.
any reason to not use createPeer?
There was a problem hiding this comment.
Spinning up libp2p nodes is overkill for unit tests. Ideally we wouldn't depend on libp2p at all in this module as libp2p itself depends on floodsub creating a loop which we really need to break in order to simplify publishing new versions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: uses new multiaddr, libp2p-interfaces, etc