This repository has been archived by the owner on Jun 15, 2023. It is now read-only.

Non-ASCII key names on MacOS #16

Closed

richardschneider opened this issue Dec 16, 2017 · 1 comment

Contributor

richardschneider commented Dec 16, 2017 •

edited

Loading

Jenkins CI is failing on macos build. I suspect its an issue with js-datastore-fs and non-ASCII key names.

 Uncaught AssertionError: expected { Object (name, id) } to deeply equal { Object (name, id) }
      + expected - actual

       {
         "id": "QmYseKb5qsWa7cB5HKMEktsG6TfbYNx7yMrauNKY3mtvHx"
      -  "name": "tajné jméno"
      +  "name": "tajné jméno"
       }

at ks.findKeyById (test/keychain.spec.js:148:31)
at listKeys (src/keychain.js:246:7)

@diasdavid Should I write test and raise an issue?

See https://stackoverflow.com/questions/9757843/unicode-encoding-for-filesystem-in-mac-os-x-not-correct-in-python and nodejs/node#2165

The text was updated successfully, but these errors were encountered:

Contributor Author

richardschneider commented Dec 16, 2017

Working with different filesystems describes the issue and how to deal with it. Basically it is saying to use string.normalize whenever comparing file names.

richardschneider mentioned this issue

test: key name comparision #17

Merged

richardschneider closed this as completed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.