fix: Only filter by wss not dns #218
Conversation
|
I think the reason this is here is because you're likely to only have a valid SSL cert on a domain name, trying to connect to an IP address via https/wss can lead to lots of error messages about invalid certificates which people find disconcerting. |
|
You can have an ssl certificate for an IP address. It's less common, but still possible. Also it's much more obvious if you see a SSL cert error rather than a "No valid address error", but that's a separate discussion. |
|
Fair enough. Can you please add the |
|
@achingbrain I added back the |
## [5.0.4](v5.0.3...v5.0.4) (2023-03-03) ### Bug Fixes * Only filter by wss not dns ([#218](#218)) ([434d44c](434d44c)) ### Trivial Changes * Update .github/workflows/semantic-pull-request.yml [skip ci] ([fad99cc](fad99cc)) * Update .github/workflows/semantic-pull-request.yml [skip ci] ([b1954aa](b1954aa))
|
🎉 This PR is included in version 5.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Browsers can dial IP addresses just fine. There's no need for this to be only DNS addresses.