Skip to content
This repository has been archived by the owner on May 7, 2024. It is now read-only.

test: ipv6 tests can be skipped if unsupported #88

Closed
wants to merge 1 commit into from

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Jul 19, 2023

Allows disabling of running ipv6 tests. On machines without ipv6 support, the tests hang forever. This means users without ipv6 (I suspect most CenturyLink ISP users) could not run tests before this change.

  • Adds toggle for ipv6 tests based on DISABLE_IPV6 env var.
  • CONTRIBUTING.md is also being added to mention the scenario I ran into.

Note: When running the tests, and aegir times out on serverAddr6.promise, it should fail, but it doesn't.

Copy link
Member Author

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review

@achingbrain
Copy link
Member

Please can you re-open this against the js-libp2p monorepo - https://github.com/libp2p/js-libp2p/tree/master/packages/transport-webtransport

Sorry, this is my fault for not archiving these repos yet.

@SgtPooki
Copy link
Member Author

superseded by libp2p/js-libp2p#1885

@SgtPooki SgtPooki closed this Jul 20, 2023
@SgtPooki SgtPooki deleted the test/ipv6-unsupported branch July 24, 2023 14:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants