Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature request]: Low-Level Connection Management #175

Closed
kumavis opened this issue Mar 7, 2018 · 4 comments · Fixed by #1142
Closed

[feature request]: Low-Level Connection Management #175

kumavis opened this issue Mar 7, 2018 · 4 comments · Fixed by #1142
Labels
status/ready Ready to be worked

Comments

@kumavis
Copy link
Contributor

kumavis commented Mar 7, 2018

idea:

some additional controls over establishing/denying connections

  • hooks for denying connections before they are established (when possible)
  • ConnectionManager configuration that can limit the number of connections per transport

usecase:

MetaMask is building an Ethereum light client for the browser using libp2p.
We intend to use webrtc which is resource intensive and can only safely support 2-5 active connections.
We need to be able to deny incoming webrtc connection attempts after some threshold.
@mitra42
Copy link

mitra42 commented Mar 8, 2018

This is similar to a comment I made in another thread recently, Its not clear to me why webrtc can't deny connections above a certain number which would ideally solve the crashing problem in browsers.

@pgte
Copy link
Contributor

pgte commented Mar 12, 2018

@kumavis that's great feedback, thanks!
Opened these issues on libp2p-connection-manager.

@daviddias daviddias added the status/ready Ready to be worked label Mar 19, 2018
@daviddias
Copy link
Member

@kumavis if you have some spare cycles, test out the connection manager already released in libp2p 0.22 and that will also get released in js-ipfs 0.30 ipfs/js-ipfs#1375

@pgte pgte mentioned this issue Aug 22, 2019
Closed
@jacobheun jacobheun mentioned this issue Jun 4, 2020
Closed
17 tasks
@jacobheun
Copy link
Contributor

We are aiming to slot connection gating into the 0.30 release.

@vasco-santos vasco-santos mentioned this issue Dec 11, 2020
Closed
@greenSnot greenSnot mentioned this issue Sep 8, 2021
Closed
@achingbrain achingbrain mentioned this issue Jan 24, 2022
Merged
achingbrain added a commit that referenced this issue Jan 25, 2022
@achingbrain
feat: connection gater (#1142)
ff32eba 
Port of https://github.com/libp2p/go-libp2p-core/blob/master/connmgr/gater.go

Adds a new configuration key `connectionGater` which allows denying the dialing of certain peers, individual multiaddrs and the creation of connections at certain points in the connection flow.

Fixes: #175
Refs: #744
Refs: #769

Co-authored-by: mzdws <8580712+mzdws@user.noreply.gitee.com>
maschad pushed a commit to maschad/js-libp2p that referenced this issue Jun 21, 2023
@dependabot @achingbrain
deps(dev): bump aegir from 38.1.8 to 39.0.5 (libp2p#175)
e8d7ed7 
* deps(dev): bump aegir from 38.1.8 to 39.0.5

Bumps [aegir](https://github.com/ipfs/aegir) from 38.1.8 to 39.0.5.
- [Release notes](https://github.com/ipfs/aegir/releases)
- [Changelog](https://github.com/ipfs/aegir/blob/master/CHANGELOG.md)
- [Commits](ipfs/aegir@v38.1.8...v39.0.5)

---
updated-dependencies:
- dependency-name: aegir
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore: fix linting

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: achingbrain <alex@achingbrain.net>
maschad pushed a commit to maschad/js-libp2p that referenced this issue Jun 21, 2023
@semantic-release-bot
chore(release): 7.0.1 [skip ci]
d73f310 
## [7.0.1](libp2p/js-libp2p-bootstrap@v7.0.0...v7.0.1) (2023-05-04)

### Dependencies

* **dev:** bump aegir from 38.1.8 to 39.0.5 ([libp2p#175](libp2p/js-libp2p-bootstrap#175)) ([e8d7ed7](libp2p/js-libp2p-bootstrap@e8d7ed7))
maschad pushed a commit to maschad/js-libp2p that referenced this issue Jun 21, 2023
@achingbrain
test: add a test for large transfers (libp2p#175)
0f60060
maschad pushed a commit to maschad/js-libp2p that referenced this issue Jun 21, 2023
@semantic-release-bot
chore(release): 2.0.8 [skip ci]
b8b87fa 
## [2.0.8](libp2p/js-libp2p-webrtc@v2.0.7...v2.0.8) (2023-06-12)

### Tests

* add a test for large transfers ([libp2p#175](libp2p/js-libp2p-webrtc#175)) ([0f60060](libp2p/js-libp2p-webrtc@0f60060))
achingbrain added a commit that referenced this issue Jun 27, 2023
@achingbrain
deps: update protons to 5.1.0 (#175)
c41d1fa
achingbrain pushed a commit that referenced this issue Jun 27, 2023
@semantic-release-bot
chore(release): 3.0.5 [skip ci]
63790cd 
## [3.0.5](libp2p/js-libp2p-floodsub@v3.0.4...v3.0.5) (2022-08-11)

### Dependencies

* update protons to 5.1.0 ([#175](libp2p/js-libp2p-floodsub#175)) ([c41d1fa](libp2p/js-libp2p-floodsub@c41d1fa))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: connection gater libp2p/js-libp2p
5 participants
@pgte @jacobheun @daviddias @kumavis @mitra42