Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow transports to expose a flag if the can be dialed with without having a listener #180

Closed
mkg20001 opened this issue Mar 29, 2018 · 1 comment
Closed

Allow transports to expose a flag if the can be dialed with without having a listener #180

mkg20001 opened this issue Mar 29, 2018 · 1 comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature status/ready Ready to be worked

Comments

@mkg20001
Copy link
Member

  • Version:
  • Platform:
  • Subsystem: transports

Type: enhancement

Severity: Low

Description: Allow transports to expose a flag if the can be dialed with without having a listener

Currently websockets can be used to dial peers without having a listener through a hack. But it is possible to dial peers over, say TCP, without having a listener setup for that, too. So why not expose a flag for that instead of using a ws-only hack?
@mkg20001 mkg20001 added the kind/enhancement A net-new feature or improvement to an existing feature label Mar 29, 2018
@daviddias daviddias added the status/deferred Conscious decision to pause or backlog label Jun 4, 2018
@daviddias daviddias added status/ready Ready to be worked and removed status/deferred Conscious decision to pause or backlog labels Oct 31, 2018
@achingbrain
Copy link
Member

If you don't specify a listen address for a given transport it's listen method will not be invoked, so if the transport does not support listening, that method can be a no-op - no flag required.

This issue may have lost context due to age, please re-open if it is still a concern that needs to be addressed.

maschad pushed a commit to maschad/js-libp2p that referenced this issue Jun 21, 2023
@web3-bot
sync: update CI config files (libp2p#180)
c84e16c
achingbrain added a commit that referenced this issue Jun 27, 2023
@achingbrain
docs: add warning not to use this module (#180)
49ee33b 
* docs: add warning not to use this module

Users should favour gossipsub so add a section to the readme
informing them they should not use this module.

* chore: readme
achingbrain pushed a commit that referenced this issue Jun 27, 2023
@semantic-release-bot
chore(release): 3.0.7 [skip ci]
61b13ae 
## [3.0.7](libp2p/js-libp2p-floodsub@v3.0.6...v3.0.7) (2022-09-07)

### Documentation

* add warning not to use this module ([#180](libp2p/js-libp2p-floodsub#180)) ([49ee33b](libp2p/js-libp2p-floodsub@49ee33b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement A net-new feature or improvement to an existing feature status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@achingbrain @daviddias @mkg20001