Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error: peer type not recognized #280

Closed
alanshaw opened this issue Nov 12, 2018 · 2 comments
Closed

Error: peer type not recognized #280

alanshaw opened this issue Nov 12, 2018 · 2 comments
Assignees
@jacobheun
Labels
exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked

Comments

@alanshaw
Copy link
Member

Seen here: https://ci.ipfs.team/blue/organizations/jenkins/IPFS%2Fjs-ipfs/detail/PR-1704/3/pipeline/55

  1) circuit relay
       A <-> R <-> B
         should connect:
     Error: peer type not recognized
      at setImmediate (node_modules/libp2p/src/get-peer-info.js:51:42)
      at Immediate._onImmediate (node_modules/async/internal/setImmediate.js:27:16)
      at process.topLevelDomainCallback (domain.js:121:23)
@jacobheun
Copy link
Contributor

That is one heck of a call stack! I'm not sure what's happening but my best guess is somehow the address filtering is returning undefined as the address cannot be found. If we attempt to dial with undefined it would return that error.

I'm working on an update to that circuit relay test in js-ipfs, the test is wrong. I'm also looking at improving get-peer-info to be more helpful with error responses.

@jacobheun jacobheun self-assigned this Nov 12, 2018
@jacobheun jacobheun added kind/bug A bug in existing code (including security flaws) exp/novice Someone with a little familiarity can pick up status/ready Ready to be worked P2 Medium: Good to have, but can wait until someone steps up labels Nov 12, 2018
@jacobheun jacobheun mentioned this issue Nov 12, 2018
Merged
@vasco-santos
Copy link
Member

With the latest refactor, we don't have the get-peer-info anymore. As this should not be a problem anymore, I am closing it.

maschad pushed a commit to maschad/js-libp2p that referenced this issue Jun 21, 2023
@achingbrain
fix: remove unused eslint-plugin-etc dep (libp2p#280)
41b9f06 
The eslint-plugin-etc dep causes typescript 5 to be selected.
maschad pushed a commit to maschad/js-libp2p that referenced this issue Jun 21, 2023
@semantic-release-bot
chore(release): 8.0.2 [skip ci]
72f1b37 
## [8.0.2](libp2p/js-libp2p-mplex@v8.0.1...v8.0.2) (2023-05-17)

### Bug Fixes

* remove unused eslint-plugin-etc dep ([libp2p#280](libp2p/js-libp2p-mplex#280)) ([41b9f06](libp2p/js-libp2p-mplex@41b9f06))

### Dependencies

* **dev:** bump aegir from 38.1.8 to 39.0.6 ([libp2p#278](libp2p/js-libp2p-mplex#278)) ([3c7229b](libp2p/js-libp2p-mplex@3c7229b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobheun jacobheun

Labels
exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alanshaw @jacobheun @vasco-santos