Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to run npm i in root folder before trying example #920

Closed
D4nte opened this issue Apr 21, 2021 · 1 comment · Fixed by #921
Closed

Need to run npm i in root folder before trying example #920

D4nte opened this issue Apr 21, 2021 · 1 comment · Fixed by #921

Comments

@D4nte
Copy link
Contributor

D4nte commented Apr 21, 2021

Type: Bug

Severity: Very Low

Description:

The js-libp2p/examples/libp2p-in-the-browser readme says to run nom install in the example folder.
This leads to the error below.
Instead, it should say to run npm install in the root folder first.

I am happy to open a PR later this week.

Steps to reproduce the error:

cd js-libp2p/examples/libp2p-in-the-browser
▶ npm install
npm WARN deprecated request-promise-native@1.0.9: request-promise-native has been deprecated because it extends the now deprecated request package, see https://github.com/request/request/issues/3142
npm WARN deprecated har-validator@5.1.5: this library is no longer supported
npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated debug@4.1.1: Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
npm WARN deprecated debug@4.1.1: Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
npm WARN deprecated debug@4.1.1: Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated core-js@2.6.12: core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.
npm ERR! code 1
npm ERR! path /home/froyer/src/libp2p/js-libp2p
npm ERR! command failed
npm ERR! command sh -c aegir build --no-bundle
npm ERR! Error: Cannot find module 'es6-promisify'
npm ERR! Require stack:
npm ERR! - /home/froyer/src/libp2p/js-libp2p/src/nat-manager.js
npm ERR! - /home/froyer/src/libp2p/js-libp2p/src/index.js
npm ERR! - /home/froyer/src/libp2p/js-libp2p/.aegir.js
npm ERR! - /home/froyer/src/libp2p/js-libp2p/node_modules/aegir/src/utils.js
npm ERR! - /home/froyer/src/libp2p/js-libp2p/node_modules/aegir/src/config/user.js
npm ERR! - /home/froyer/src/libp2p/js-libp2p/node_modules/aegir/cli.js
npm ERR!     at Function.Module._resolveFilename (node:internal/modules/cjs/loader:924:15)
npm ERR!     at Function.Module._load (node:internal/modules/cjs/loader:769:27)
npm ERR!     at Module.require (node:internal/modules/cjs/loader:996:19)
npm ERR!     at require (node:internal/modules/cjs/helpers:92:18)
npm ERR!     at Object.<anonymous> (/home/froyer/src/libp2p/js-libp2p/src/nat-manager.js:6:23)
npm ERR!     at Module._compile (node:internal/modules/cjs/loader:1092:14)
npm ERR!     at Object.Module._extensions..js (node:internal/modules/cjs/loader:1121:10)
npm ERR!     at Module.load (node:internal/modules/cjs/loader:972:32)
npm ERR!     at Function.Module._load (node:internal/modules/cjs/loader:813:14)
npm ERR!     at Module.require (node:internal/modules/cjs/loader:996:19) {
npm ERR!   code: 'MODULE_NOT_FOUND',
npm ERR!   requireStack: [
npm ERR!     '/home/froyer/src/libp2p/js-libp2p/src/nat-manager.js',
npm ERR!     '/home/froyer/src/libp2p/js-libp2p/src/index.js',
npm ERR!     '/home/froyer/src/libp2p/js-libp2p/.aegir.js',
npm ERR!     '/home/froyer/src/libp2p/js-libp2p/node_modules/aegir/src/utils.js',
npm ERR!     '/home/froyer/src/libp2p/js-libp2p/node_modules/aegir/src/config/user.js',
npm ERR!     '/home/froyer/src/libp2p/js-libp2p/node_modules/aegir/cli.js'
npm ERR!   ]
npm ERR! }
npm ERR! Error: Cannot find module 'es6-promisify'
npm ERR! Require stack:
npm ERR! - /home/froyer/src/libp2p/js-libp2p/src/nat-manager.js
npm ERR! - /home/froyer/src/libp2p/js-libp2p/src/index.js
npm ERR! - /home/froyer/src/libp2p/js-libp2p/.aegir.js
npm ERR! - /home/froyer/src/libp2p/js-libp2p/node_modules/aegir/src/utils.js
npm ERR! - /home/froyer/src/libp2p/js-libp2p/node_modules/aegir/src/config/webpack.config.js
npm ERR! - /home/froyer/src/libp2p/js-libp2p/node_modules/webpack-cli/bin/utils/convert-argv.js
npm ERR! - /home/froyer/src/libp2p/js-libp2p/node_modules/webpack-cli/bin/cli.js
npm ERR!     at Function.Module._resolveFilename (node:internal/modules/cjs/loader:924:15)
npm ERR!     at Function.Module._load (node:internal/modules/cjs/loader:769:27)
npm ERR!     at Module.require (node:internal/modules/cjs/loader:996:19)
npm ERR!     at require (/home/froyer/src/libp2p/js-libp2p/node_modules/v8-compile-cache/v8-compile-cache.js:159:20)
npm ERR!     at Object.<anonymous> (/home/froyer/src/libp2p/js-libp2p/src/nat-manager.js:6:23)
npm ERR!     at Module._compile (/home/froyer/src/libp2p/js-libp2p/node_modules/v8-compile-cache/v8-compile-cache.js:192:30)
npm ERR!     at Object.Module._extensions..js (node:internal/modules/cjs/loader:1121:10)
npm ERR!     at Module.load (node:internal/modules/cjs/loader:972:32)
npm ERR!     at Function.Module._load (node:internal/modules/cjs/loader:813:14)
npm ERR!     at Module.require (node:internal/modules/cjs/loader:996:19)
npm ERR!     at require (/home/froyer/src/libp2p/js-libp2p/node_modules/v8-compile-cache/v8-compile-cache.js:159:20)
npm ERR!     at Object.<anonymous> (/home/froyer/src/libp2p/js-libp2p/src/index.js:35:20)
npm ERR!     at Module._compile (/home/froyer/src/libp2p/js-libp2p/node_modules/v8-compile-cache/v8-compile-cache.js:192:30)
npm ERR!     at Object.Module._extensions..js (node:internal/modules/cjs/loader:1121:10)
npm ERR!     at Module.load (node:internal/modules/cjs/loader:972:32)
npm ERR!     at Function.Module._load (node:internal/modules/cjs/loader:813:14)
npm ERR!     at Module.require (node:internal/modules/cjs/loader:996:19)
npm ERR!     at require (/home/froyer/src/libp2p/js-libp2p/node_modules/v8-compile-cache/v8-compile-cache.js:159:20)
npm ERR!     at Object.<anonymous> (/home/froyer/src/libp2p/js-libp2p/.aegir.js:4:16)
npm ERR!     at Module._compile (/home/froyer/src/libp2p/js-libp2p/node_modules/v8-compile-cache/v8-compile-cache.js:192:30)
npm ERR!     at Object.Module._extensions..js (node:internal/modules/cjs/loader:1121:10)
npm ERR!     at Module.load (node:internal/modules/cjs/loader:972:32)
npm ERR!     at Function.Module._load (node:internal/modules/cjs/loader:813:14)
npm ERR!     at Module.require (node:internal/modules/cjs/loader:996:19)
npm ERR!     at require (/home/froyer/src/libp2p/js-libp2p/node_modules/v8-compile-cache/v8-compile-cache.js:159:20)
npm ERR!     at Object.exports.getUserConfig (/home/froyer/src/libp2p/js-libp2p/node_modules/aegir/src/utils.js:110:12)
npm ERR!     at userConfig (/home/froyer/src/libp2p/js-libp2p/node_modules/aegir/src/config/user.js:32:28)
npm ERR!     at Object.<anonymous> (/home/froyer/src/libp2p/js-libp2p/node_modules/aegir/src/config/webpack.config.js:9:37)
npm ERR!     at Module._compile (/home/froyer/src/libp2p/js-libp2p/node_modules/v8-compile-cache/v8-compile-cache.js:192:30)
npm ERR!     at Object.Module._extensions..js (node:internal/modules/cjs/loader:1121:10) {
npm ERR!   code: 'MODULE_NOT_FOUND',
npm ERR!   requireStack: [
npm ERR!     '/home/froyer/src/libp2p/js-libp2p/src/nat-manager.js',
npm ERR!     '/home/froyer/src/libp2p/js-libp2p/src/index.js',
npm ERR!     '/home/froyer/src/libp2p/js-libp2p/.aegir.js',
npm ERR!     '/home/froyer/src/libp2p/js-libp2p/node_modules/aegir/src/utils.js',
npm ERR!     '/home/froyer/src/libp2p/js-libp2p/node_modules/aegir/src/config/webpack.config.js',
npm ERR!     '/home/froyer/src/libp2p/js-libp2p/node_modules/webpack-cli/bin/utils/convert-argv.js',
npm ERR!     '/home/froyer/src/libp2p/js-libp2p/node_modules/webpack-cli/bin/cli.js'
npm ERR!   ]
npm ERR! }

@vasco-santos
Copy link
Member

vasco-santos commented Apr 21, 2021

Thanks for reporting @D4nte

Yes, please open a PR

EDIT: there is already a PR 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants