fix: connection pruning #1235
Merged
fix: connection pruning #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prune connections when we reach the connection limit
|
This is to fix a bug in the current behaviour. A follow up PR that prunes incoming connections before outgoing ones, and ranks by peer tag instead of the simple value will be necessary. |
wemeetagain
reviewed
Jun 7, 2022
src/connection-manager/index.ts
Outdated
| @@ -482,32 +482,46 @@ export class DefaultConnectionManager extends EventEmitter<ConnectionManagerEven | |||
| * to the lowest valued peer. | |||
| */ | |||
| async _maybeDisconnectOne () { | |||
There was a problem hiding this comment.
i think the name and docstring need update?
There was a problem hiding this comment.
I've changed it round to just disconnect one when we detect excessive data use/event loop slowdowns and multiple when we have too many connections.
wemeetagain
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually prune connections when we reach the connection limit