Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use same promise when closing maconn multiple times #2487

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Apr 16, 2024

Title

Use same promise when closingMultiaddrConnection multiple time

See #2478 (review)

Description

related to #2477

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@twoeths twoeths requested a review from a team as a code owner April 16, 2024 06:15
@achingbrain achingbrain merged commit ea4f262 into libp2p:main Apr 16, 2024
22 checks passed
@achingbrain
Copy link
Member

Thanks!

@twoeths
Copy link
Contributor Author

twoeths commented Apr 16, 2024

@achingbrain could you please release libp2p-tcp? would like to test this fix with lodestar v1.18 to see if the leaked sockets are still there
cc @wemeetagain

@achingbrain achingbrain mentioned this pull request Apr 16, 2024
@twoeths twoeths deleted the tuyen/close_ma_conn_same_promise branch April 17, 2024 02:22
@twoeths
Copy link
Contributor Author

twoeths commented Apr 17, 2024

v9.0.22 was released including this PR, thanks @achingbrain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants