Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use prefix binary tree for routing table #2536

Merged
merged 1 commit into from
May 10, 2024

Conversation

achingbrain
Copy link
Member

The Kademlia paper shows a simple binary tree as a data structure for the routing table. This can grow very deep for long keys so an optimisation is to only use a prefix of the KAD-ID when constructing the table.

This results in faster lookups for better performance.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

The Kademlia paper shows a simple binary tree as a data structure
for the routing table.  This can grow very deep for long keys so
an optimisation is to only use a prefix of the KAD-ID when
constructing the table.

This results in faster lookups for better performance.
@achingbrain achingbrain requested a review from a team as a code owner May 9, 2024 16:23
@achingbrain achingbrain merged commit 7ae6063 into main May 10, 2024
22 checks passed
@achingbrain achingbrain deleted the fix/use-prefix-binary-tree branch May 10, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant