fix: validate dht config #286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
vasco-santos
force-pushed
the
fix/validate-dht-config
branch
from
3e9db30
to
e6e1772
Compare
vasco-santos
force-pushed
the
fix/validate-dht-config
branch
from
e6e1772
to
ff5316d
Compare
jacobheun
suggested changes
Nov 26, 2018
There was a problem hiding this comment.
@vasco-santos i think we should just fix the defaults in the config file. When the validator runs it will automatically add them so we don't hit this issue. I think it's a simpler change. I pushed a quick commit with a test to show what I mean: 9abb0c0
|
Yes, your solution sounds way better. Can you create the PR with it? |
Closed
|
Closing in favor of #289 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of the issue reported ipfs/js-ipfs#1657#issuecomment-440758206