Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sign pubsub messages #362

Merged
merged 3 commits into from May 7, 2019

Conversation

2 participants
@jacobheun
Copy link
Contributor

commented May 6, 2019

This upgrades floodsub so that all messages published are signed

Requires libp2p/js-libp2p-floodsub#78

I ran libp2p/interop against this branch to verify it's passing, https://github.com/libp2p/interop/runs/119819194

fix: forward pubsub publish callback to floodsub
chore: update floodsub version

@ghost ghost assigned jacobheun May 6, 2019

@ghost ghost added the in progress label May 6, 2019

@jacobheun jacobheun requested a review from vasco-santos May 6, 2019

@vasco-santos
Copy link
Member

left a comment

LGTM! Just needs the libp2p-floodsub updated

Show resolved Hide resolved package.json Outdated

@jacobheun jacobheun merged commit 40978a1 into master May 7, 2019

5 of 6 checks passed

bundlesize ./dist/index.min.js: 221.18KB > maxSize 218KB (gzip)
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
Windows Tests #84 succeeded
Details
codecov/patch 100% of diff hit (target 96.92%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +3.07% compared to 71dcaaf
Details

@jacobheun jacobheun deleted the fix/pubsub-signing branch May 7, 2019

@ghost ghost removed the in progress label May 7, 2019

@alanshaw alanshaw referenced this pull request May 21, 2019

Closed

⚡️ v0.36.0 RELEASE 🚀 #2024

43 of 44 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.