Skip to content
This repository has been archived by the owner on Feb 11, 2020. It is now read-only.

can not set pub and priv key on peer-info #33

Closed
dignifiedquire opened this issue Mar 31, 2017 · 3 comments
Closed

can not set pub and priv key on peer-info #33

dignifiedquire opened this issue Mar 31, 2017 · 3 comments
Assignees
@daviddias
Labels
bug difficulty:easy

Comments

@dignifiedquire
Copy link
Member

They don't have setters currently so

throw. Should add a test here for this and add setters on peer-info
@dignifiedquire
Copy link
Member Author

cc @diasdavid

@daviddias
Copy link
Member

You mean peer-id, right? https://github.com/libp2p/js-peer-id/blob/master/src/index.js#L34-L46

Got it

@daviddias daviddias self-assigned this Apr 2, 2017
@daviddias daviddias mentioned this issue Apr 2, 2017
Closed
@daviddias
Copy link
Member

This has been done :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@daviddias daviddias

Labels
bug difficulty:easy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dignifiedquire @daviddias