Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setters for the keys #59

Closed
daviddias opened this issue Apr 2, 2017 · 2 comments
Closed

Add setters for the keys #59

daviddias opened this issue Apr 2, 2017 · 2 comments
Assignees
@daviddias

Comments

@daviddias
Copy link
Member

to fix libp2p/js-peer-book#33

make sure that on set of the priv key, the pubkey still matches.
@daviddias daviddias self-assigned this Apr 2, 2017
@dryajov
Copy link
Member

dryajov commented Apr 2, 2017

@diasdavid I'll add this, as I need them for circuit. Any considerations that I should take into account?

@daviddias
Copy link
Member Author

@dryajov check here: #60 needs better checking. It is annoying because we can't really verify on set (all crypto must be async)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daviddias daviddias

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dryajov @daviddias