Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct case for RSA keyType #136

Merged
merged 2 commits into from Jan 6, 2021
Merged

Conversation

acolytec3
Copy link
Contributor

@acolytec3 acolytec3 commented Jan 6, 2021

Typescript complains if you use rsa instead of RSA for the keyType so this will correct the examples in the documentation to match the keyType exported from libp2p-crypto.

correct case of rsa keytype in docs/examples to match keyType exported from libp2p-crypto
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Requested an inline change

README.md Outdated Show resolved Hide resolved
Co-authored-by: Vasco Santos <vasco.santos@ua.pt>
@vasco-santos vasco-santos merged commit 41ab96c into libp2p:master Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants