isPeerId #57
isPeerId #57
Conversation
src/index.js
Outdated
| @@ -219,6 +219,12 @@ exports.createFromJSON = function (obj, callback) { | |||
| } | |||
| } | |||
|
|
|||
| exports.isPeerId = function (peerId) { | |||
| if (peerId.constructor && peerId.constructor.name) { | |||
| return peerId.constructor.name === 'PeerId' | |||
There was a problem hiding this comment.
We can't do this I'm afraid, see libp2p/js-libp2p#65
There was a problem hiding this comment.
oh, it is even weird that this has only appeared now as an issue
There was a problem hiding this comment.
I wish instanceof would just work..
There was a problem hiding this comment.
We can use symbols for this
const peerIdSymbol = Symbol('PeerId')
class PeerId {
constructor () {
this[peerIdSymbol] = true
}
static isPeerId (other) {
return other && other[peerIdSymbol]
}
}There was a problem hiding this comment.
Saw this comment after pushed my change. Seems that Symbols won't work since they are different if different instances are created:
Making two versions (even patch) of peer-id different.
There was a problem hiding this comment.
that's the point of symbols, you reuse the same symbol on all instances as you can see above in my example
There was a problem hiding this comment.
You won't reuse if there is a js-peer-id 0.n.x and a 0.n+1.x.
|
Issue mitigated, will move forward with this PR. Will leave libp2p/js-libp2p#65 open for ideas. |
No description provided.