Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mplex: implement protocol Netty handler #16

Closed
Nashatyrev opened this issue Jul 5, 2019 · 1 comment
Closed

mplex: implement protocol Netty handler #16

Nashatyrev opened this issue Jul 5, 2019 · 1 comment
Assignees
@snazha-blkio
Projects
Minimal implementation

Comments

@Nashatyrev
Copy link
Collaborator

Implement the codec which will encode/decode mplex frames to/from objects like below:

streamId: Long
flag: MplexFrameFlag
data: ByteBuf

Enforce the protocol rules like correct order of frame flags, writing to closed stream, duplicate Ids, etc
@Nashatyrev Nashatyrev mentioned this issue Jul 5, 2019
Closed
@snazha-blkio snazha-blkio moved this from To do to In progress in Minimal implementation Jul 5, 2019
@snazha-blkio
Copy link
Contributor

Our stream is being closed (via a Reset message) because /ipfs/id/1.0.0 is expecting an Identify message to have previously been sent.

Awaiting some guidance on how to handle this.

@Nashatyrev Nashatyrev mentioned this issue Jul 11, 2019
Closed
Nashatyrev added a commit that referenced this issue Jul 18, 2019
@Nashatyrev
Merge pull request #26 from libp2p/feature/mplex
f2b8454 
WIP: mplex implementation.
Resolve #16
@Nashatyrev Nashatyrev moved this from In progress to Done in Minimal implementation Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snazha-blkio snazha-blkio

Labels
None yet
Projects
No open projects
Minimal implementation
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Nashatyrev @snazha-blkio