Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Yamux] Increase write buffer size and make it configurable #317

Merged
merged 3 commits into from
Sep 12, 2023
Merged

[Yamux] Increase write buffer size and make it configurable #317

merged 3 commits into from
Sep 12, 2023

Conversation

StefanBratanov
Copy link
Collaborator

@StefanBratanov StefanBratanov commented Sep 12, 2023 •
edited

  • Make maxBufferedConnectionWrites configurable and default it to 10MiB
  • Release and clear buffer when overflowed.

Nashatyrev
Nashatyrev approved these changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@Nashatyrev Nashatyrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Would be nice as well to add a test checking the parameter is respected

Nashatyrev
Nashatyrev approved these changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@Nashatyrev Nashatyrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StefanBratanov StefanBratanov merged commit 9c8dfaf into libp2p:develop Sep 12, 2023
2 checks passed
@StefanBratanov StefanBratanov deleted the yamux_increase_buffer_size branch September 12, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nashatyrev Nashatyrev Nashatyrev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@StefanBratanov @Nashatyrev