New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python to REQUIREMENTS.md #65
Conversation
@zixuanzh This LGTM, but you're in a better position than me to double check for accuracy relative to the current state of py-libpo2p. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zixuanzh what do you mean by :
I don't find multisteam-select in https://github.com/zixuanzh/py-libp2p/tree/master/libp2p/stream_muxer
Done ! 😄 |
This is to according to change done in libp2p/py-libp2p#117
@Jorropo we implemented |
README.md
Outdated
@@ -30,6 +30,7 @@ Meanwhile, learn more about libp2p at [**libp2p.io**](https://libp2p.io) | |||
- [go-libp2p](//github.com/libp2p/go-libp2p) in Go | |||
- [js-libp2p](//github.com/libp2p/js-libp2p) in Javascript, for Node and the Browser | |||
- [rust-libp2p](//github.com/libp2p/rust-libp2p) in Rust | |||
- [py-libp2p](//github.com/zixuanzh/py-libp2p) in Python 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's specify Python 3.7 to avoid confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I should precise async, this is for me important to know if the lib support that or not ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you talking about asyncio? I think specifying 3.7 should be sufficient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jorropo we are moving into libp2p org today, so lets use //github.com/libp2p/py-libp2p instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For async I think you are right. That made it unclear.
@zixuanzh I'm felling very idiot because I don't understand what you are talking about, that surely obvious but I can't get it. In REQUIREMENT.md I find these category :
And So please can you help me to catch it ? |
Hi @Jorropo, indeed I think it is okay to leave it out of the REQUIREMENTS, and we may eventually remove it ourselves too. So this PR looks ready to me. |
@Jorropo sorry for the confusion, @robzajac is correct. Stream Muxers allow two nodes to agree on a stream id to communicate on and Protocol Muxers/Multistreams allow two nodes to agree on a protocol for a particular stream. Let's change the link in README since the repo was just transferred today and it should be good to go. Thank you! |
The python implementation can be found here :
github.com/zixuanzh/py-libp2p