Trio: fix host, peer, protocols, and examples #398
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
ChihChengLiang
approved these changes
Jan 22, 2020
| muxer_opt: TMuxerOptions = None, | ||
| sec_opt: TSecurityOptions = None, | ||
| peerstore_opt: IPeerStore = None, | ||
| ) -> Swarm: | ||
| ) -> INetworkService: |
There was a problem hiding this comment.
Why are we changing to a more abstract type to the function output here?
There was a problem hiding this comment.
I intended to use interfaces over implementations. I can change it back if you think it's more reasonable.
There was a problem hiding this comment.
Using interfaces sounds good 👍
There was a problem hiding this comment.
Agreed. This has helped us a lot in both the trinity and py-evm codebases to establish concrete interface definitions and to use them ubiquitously in our type hints.
|
Closed by #365 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the #365: