*: add default None for Transport::address_translation

libp2p · Oct 4, 2022 · 3785dd8 · 3785dd8
1 parent de05313
commit 3785dd8
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 18 deletions.
diff --git a/core/src/transport.rs b/core/src/transport.rs
@@ -164,7 +164,9 @@ pub trait Transport {
     ///
     /// Note: if the listen or observed address is not a valid address of this transport,
     /// `None` should be returned as well.
-    fn address_translation(&self, listen: &Multiaddr, observed: &Multiaddr) -> Option<Multiaddr>;
+    fn address_translation(&self, _listen: &Multiaddr, _observed: &Multiaddr) -> Option<Multiaddr> {
+        None
+    }
 
     /// Boxes the transport, including custom transport errors.
     fn boxed(self) -> boxed::Boxed<Self::Output>

diff --git a/core/src/transport/dummy.rs b/core/src/transport/dummy.rs
@@ -78,10 +78,6 @@ impl<TOut> Transport for DummyTransport<TOut> {
         Err(TransportError::MultiaddrNotSupported(addr))
     }
 
-    fn address_translation(&self, _server: &Multiaddr, _observed: &Multiaddr) -> Option<Multiaddr> {
-        None
-    }
-
     fn poll(
         self: Pin<&mut Self>,
         _: &mut Context<'_>,

diff --git a/core/src/transport/memory.rs b/core/src/transport/memory.rs
@@ -239,10 +239,6 @@ impl Transport for MemoryTransport {
         self.dial(addr)
     }
 
-    fn address_translation(&self, _server: &Multiaddr, _observed: &Multiaddr) -> Option<Multiaddr> {
-        None
-    }
-
     fn poll(
         mut self: Pin<&mut Self>,
         cx: &mut Context<'_>,

diff --git a/protocols/relay/src/v2/client/transport.rs b/protocols/relay/src/v2/client/transport.rs
@@ -222,9 +222,7 @@ impl Transport for ClientTransport {
         Err(TransportError::MultiaddrNotSupported(addr))
     }
 
-    fn address_translation(&self, _server: &Multiaddr, _observed: &Multiaddr) -> Option<Multiaddr> {
-        None
-    }
+
 
     fn poll(
         mut self: Pin<&mut Self>,

diff --git a/transports/dns/src/lib.rs b/transports/dns/src/lib.rs
@@ -621,9 +621,7 @@ mod tests {
                 self.dial(addr)
             }
 
-            fn address_translation(&self, _: &Multiaddr, _: &Multiaddr) -> Option<Multiaddr> {
-                None
-            }
+
 
             fn poll(
                 self: Pin<&mut Self>,

diff --git a/transports/wasm-ext/src/lib.rs b/transports/wasm-ext/src/lib.rs
@@ -237,9 +237,7 @@ impl Transport for ExtTransport {
         self.do_dial(addr, Endpoint::Listener)
     }
 
-    fn address_translation(&self, _server: &Multiaddr, _observed: &Multiaddr) -> Option<Multiaddr> {
-        None
-    }
+
 
     fn poll(
         mut self: Pin<&mut Self>,