Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mDNS not compatible with go #1678

Closed
semtexzv opened this issue Jul 26, 2020 · 3 comments
Closed

mDNS not compatible with go #1678

semtexzv opened this issue Jul 26, 2020 · 3 comments

Comments

@semtexzv
Copy link

I have implementation of simple p2p application running in both go and rust. When testing, go can reach go nodes using mDNS, and rust can reach rust nodes, but not accross. It seems that the implementations are incompatible.

Go code:
https://github.com/semtexzv/go-ipcs/blob/master/node/node.go
Rust code:
https://github.com/semtexzv/ipcs/blob/master/node/src/net/mod.rs

@tomaka
Copy link
Member

tomaka commented Jul 27, 2020

As far as I know, rust-libp2p follows the libp2p specifications, and it's Go and JS which aren't compliant here.

@semtexzv
Copy link
Author

Just opened https://github.com/libp2p/specs/blob/master/discovery/mdns.md. Seems you're right

Rust uses the _p2p._udp.local service name, while go uses _ipfs-discovery._udp.local.

@gobengo
Copy link

gobengo commented Jun 13, 2023

it's Go and JS which aren't compliant here.

It appears that js-libp2p-mdns uses the newest specced _p2p._udp.local as of version 7 in March 2023
https://github.com/libp2p/js-libp2p-mdns/blame/cb8e2aebf46381038f6959a2c7dbd1f10c68a301/src/index.ts#L43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants