Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webrtc/tests: data channel opening took longer than 10 seconds #3223

Closed
mxinden opened this issue Dec 9, 2022 · 0 comments · Fixed by #3023
Closed

webrtc/tests: data channel opening took longer than 10 seconds #3223

mxinden opened this issue Dec 9, 2022 · 0 comments · Fixed by #3023
Labels
bug

Comments

@mxinden
Copy link
Member

mxinden commented Dec 9, 2022

Summary

Test smoke times out with:

test smoke ... FAILED

failures:

---- smoke stdout ----
thread 'smoke' panicked at 'called `Result::unwrap()` on an `Err` value: Custom { kind: Other, error: Internal("data channel opening took longer than 10 seconds (see logs)") }', transports/webrtc/tests/smoke.rs:270:42

error: test failed, to rerun pass `-p libp2p-webrtc --test smoke`

failures:
    smoke

test result: FAILED. 1 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 10.01s

https://github.com/libp2p/rust-libp2p/actions/runs/3659637005/jobs/6186244264 on #3023

Expected behaviour

Test to succeed.

Would you like to work on fixing this bug?

No. Also let's see whether this fails more often before investigating.
@mxinden mxinden added the bug label Dec 9, 2022
@mxinden mxinden mentioned this issue Dec 9, 2022
Merged
4 tasks
@thomaseizinger thomaseizinger linked a pull request Dec 12, 2022 that will close this issue
fix: Remove circular dependencies across workspace #3023
Merged
4 tasks
@mergify mergify bot closed this as completed in #3023 Dec 12, 2022
mergify bot pushed a commit that referenced this issue Dec 12, 2022
@thomaseizinger
fix: Remove circular dependencies across workspace (#3023)
d7363a5 
Circular dependencies are problematic in several ways:

- They result in cognitive overhead for developers, in trying to figure out what depends on what.
- They present `cargo` with limits in what order the crates can be compiled in.
- They invalidate build caches unnecessarily thus forcing `cargo` to rebuild certain crates.
- They cause problems with tooling such as `release-please`.

To actually break the circular dependencies, this patch inlines the uses of `development_transport` in the examples and tests for all sub-crates. This is only meant to be a short-term fix until #3111 and #2888 are fixed.

To ensure we don't accidentally reintroduce this dependency, we add a basic CI that queries `cargo metadata` using `jq`.

Resolves #3053.
Fixes #3223.
Related: #2918 (comment)
Related: googleapis/release-please#1662
umgefahren pushed a commit to umgefahren/rust-libp2p that referenced this issue Mar 8, 2024
@thomaseizinger
fix: Remove circular dependencies across workspace (libp2p#3023)
05dd63d 
Circular dependencies are problematic in several ways:

- They result in cognitive overhead for developers, in trying to figure out what depends on what.
- They present `cargo` with limits in what order the crates can be compiled in.
- They invalidate build caches unnecessarily thus forcing `cargo` to rebuild certain crates.
- They cause problems with tooling such as `release-please`.

To actually break the circular dependencies, this patch inlines the uses of `development_transport` in the examples and tests for all sub-crates. This is only meant to be a short-term fix until libp2p#3111 and libp2p#2888 are fixed.

To ensure we don't accidentally reintroduce this dependency, we add a basic CI that queries `cargo metadata` using `jq`.

Resolves libp2p#3053.
Fixes libp2p#3223.
Related: libp2p#2918 (comment)
Related: googleapis/release-please#1662
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Remove circular dependencies across workspace libp2p/rust-libp2p
1 participant
@mxinden