Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace custom-clippy alias with workspace-wide [lints] configuration #4484

Closed
thomaseizinger opened this issue Sep 11, 2023 · 2 comments · Fixed by #4575
Closed

replace custom-clippy alias with workspace-wide [lints] configuration #4484

thomaseizinger opened this issue Sep 11, 2023 · 2 comments · Fixed by #4575
Assignees
@binsta
Labels
difficulty:easy help wanted

Comments

@thomaseizinger
Copy link
Contributor

Currently, we have an alias for standardizing our lint configuration:

rust-libp2p/.cargo/config.toml

Line 3 in 240019f

custom-clippy = "clippy --workspace --all-features --all-targets -- -A clippy::type_complexity -A clippy::pedantic -W clippy::used_underscore_binding -W unreachable_pub"

There is a new cargo feature on the way that allows to configure lints in the Cargo.toml. Together with workspace-inheritance, we should be able to move our lint configuration away from the alias to a configuration that is only specified once in our root Cargo.toml.

Here is the tracking issue: rust-lang/cargo#12115

This should stable from nightly-2023-09-10 onwards. We should be able to start experimenting with this by adding the relevant nightly toolchain here:

rust-libp2p/.github/workflows/ci.yml

Lines 202 to 205 in 240019f

rust-version: [
1.72.0, # current stable
beta
]
and moving the configuration from custom-clippy over to Cargo.toml.

Contributions welcome!
@binsta
Copy link
Contributor

binsta commented Sep 30, 2023

can i take this one @thomaseizinger

@binsta binsta mentioned this issue Sep 30, 2023
Merged
4 tasks
@thomaseizinger
Copy link
Contributor Author

can i take this one @thomaseizinger

Yes! Thank you :)

@mergify mergify bot closed this as completed in #4575 Oct 9, 2023
mergify bot pushed a commit that referenced this issue Oct 9, 2023
@binsta
ci: use workspace inheritance to enforce lints in all crates
0e9d339 
Starting with nightly-2023-09-10, the `[lints]` section in `Cargo.toml` files is stable. Together with workspace inheritance, this can be used to declare all lints we want to enforce in a single place.

Resolves: #4484.

Pull-Request: #4575.
monoid pushed a commit to fluencelabs/rust-libp2p that referenced this issue Oct 9, 2023
@binsta @monoid
ci: use workspace inheritance to enforce lints in all crates
1b7afe7 
Starting with nightly-2023-09-10, the `[lints]` section in `Cargo.toml` files is stable. Together with workspace inheritance, this can be used to declare all lints we want to enforce in a single place.

Resolves: libp2p#4484.

Pull-Request: libp2p#4575.
umgefahren pushed a commit to umgefahren/rust-libp2p that referenced this issue Mar 8, 2024
@binsta
ci: use workspace inheritance to enforce lints in all crates
6dd90d0 
Starting with nightly-2023-09-10, the `[lints]` section in `Cargo.toml` files is stable. Together with workspace inheritance, this can be used to declare all lints we want to enforce in a single place.

Resolves: libp2p#4484.

Pull-Request: libp2p#4575.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@binsta binsta

Labels
difficulty:easy help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: use workspace inheritance to enforce lints in all crates binsta/rust-libp2p
2 participants
@thomaseizinger @binsta