Fix ED25519 signature validation #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
approved these changes
May 15, 2019
|
Hmm, probably worth notifying the cargo audit people. cc @kirushik |
romanb
approved these changes
May 15, 2019
ghost
assigned 
tomaka
pushed a commit
to tomaka/libp2p-rs
that referenced
this pull request
May 15, 2019
This was referenced May 15, 2019
tarcieri
reviewed
May 15, 2019
| @@ -100,7 +100,7 @@ pub struct PublicKey(ed25519::PublicKey); | |||
| impl PublicKey { | |||
| /// Verify the Ed25519 signature on a message using the public key. | |||
| pub fn verify(&self, msg: &[u8], sig: &[u8]) -> bool { | |||
There was a problem hiding this comment.
You might want to consider changing this method to return a Result<(), ()> so as to strategically avoid this bugclass in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ED25519 verify method wasn't checking if the actual verification was successful, but was only checking if the signature decoding was successful.
The RSA and Secp256k1 keys logic looks valid.