Merge of #116 and #111 #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
|
I'll leave comments on the respective PRs instead of here, since it's easier to review these independently. |
eira-fransham
approved these changes
Mar 7, 2018
tomaka
force-pushed
the
identify-merge-connec-reuse
branch
from
43d8d69
to
03c4c8f
Compare
tomaka
force-pushed
the
identify-merge-connec-reuse
branch
from
03c4c8f
to
e406fc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the conflicts between the two branches were tricky to resolve, I opened this PR with #116 and #111 merged together.