Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix floodsub with new futures #1249

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Fix floodsub with new futures #1249

merged 1 commit into from
Oct 7, 2019

Conversation

tomaka
Copy link
Member

@tomaka tomaka commented Sep 19, 2019 •
edited

I had already done most of the work, but had paused it before of the lack of transfer functions at the time.

mxinden
mxinden approved these changes Oct 4, 2019
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how much my review is worth but this looks good to me.

@tomaka tomaka merged commit 6667fb8 into libp2p:stable-futures Oct 7, 2019
@tomaka tomaka deleted the fix-floodsub branch October 7, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tomaka @mxinden