Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rw-stream-sink to futures-0.3. #1301

Closed
wants to merge 1 commit into from
Closed

Update rw-stream-sink to futures-0.3. #1301

wants to merge 1 commit into from

Conversation

twittner
Copy link
Contributor

No description provided.

tomaka
tomaka previously approved these changes Nov 12, 2019
View reviewed changes
Copy link
Member

@tomaka tomaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with whatever direction rw-stream-sink takes in terms of API, as long as the rest of rust-libp2p compiles with it.

@tomaka tomaka dismissed their stale review November 12, 2019 12:30

I still would like to review the logic of the code once the PR is final, in case I spot a mistake.

@twittner
Copy link
Contributor Author

[...] as long as the rest of rust-libp2p compiles with it.

Indeed, I just rebased (did not think you would review so quickly), as it was not working well with the rest of the code base. I am working my way through, core, tcp, secio, mplex, etc. The new version is far less disruptive as it is back to using a single type parameter.

I still would like to review the logic of the code once the PR is final, in case I spot a mistake.

By all means. Please note that fwiw at least the tests in rw-stream-sink have been ported as well and run successfully.

twittner added a commit to twittner/rust-libp2p that referenced this pull request Nov 12, 2019
@twittner
Update core, tcp, secio and mplex to futures-0.3.
3ddd6ea 
On top of libp2p#1301
@twittner
Copy link
Contributor Author

If you prefer we could also close this PR in preference for #1302 which is based on this one and accumulate the changes for futures-0.3 there first.

tomaka pushed a commit that referenced this pull request Nov 14, 2019
@twittner @tomaka
Update core, tcp, secio and mplex to futures-0.3. (#1302)
f85241d 
* Update `rw-stream-sink` to futures-0.3.

* Update core, tcp, secio and mplex to futures-0.3.

On top of #1301
@tomaka tomaka closed this Nov 14, 2019
@twittner twittner deleted the rw-stream-sink-futures-0.3 branch November 14, 2019 12:53
mxinden pushed a commit to mxinden/rust-libp2p that referenced this pull request Nov 14, 2019
@twittner @mxinden
Update core, tcp, secio and mplex to futures-0.3.
d757d96 
On top of libp2p#1301
santos227 pushed a commit to santos227/rustlib that referenced this pull request Jun 20, 2022
@twittner @tomaka
Update core, tcp, secio and mplex to futures-0.3. (#1302)
2b84251 
* Update `rw-stream-sink` to futures-0.3.

* Update core, tcp, secio and mplex to futures-0.3.

On top of libp2p/rust-libp2p#1301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaka tomaka tomaka left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@twittner @tomaka