Remove all mod.rs files #1400
Merged
Remove all mod.rs files #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@tomaka can you cite a reference here? I could only find doc.rust-lang.org and this reddit article but neither say that one is encouraged over the other. 👍 for being consistent across the project, whichever style we use. |
|
Ping for reviews? |
romanb
approved these changes
Jan 27, 2020
mxinden
added a commit
to mxinden/rust-libp2p
that referenced
this pull request
Nov 10, 2021
To be consistent with the rest of the codebase, use harness.rs instead of mod.rs. See also libp2p#1400
santos227
pushed a commit
to santos227/rustlib
that referenced
this pull request
Jun 20, 2022
… (#2335) To be consistent with the rest of the codebase, use harness.rs instead of mod.rs. See also libp2p/rust-libp2p#1400
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of Rust edition 2018, you are now encouraged to use
foo.rsrather thanfoo/mod.rs.Half of the code of
rust-libp2pwas using the old idiom, and the other half the new idiom. This PR unifies all of this.