core/src: Remove poll_broadcast connection notification mechanism #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Network::poll_broadcast` function has not proven to be useful. This commit removes the mechanism all the way down to the connection manager. With `poll_broadcast` gone there is no mechanism left to send commands to pending connections. Thereby command buffering for pending connections is not needed anymore and is thus removed in this commit as well.
romanb
approved these changes
Mar 30, 2020
tomaka
approved these changes
Mar 30, 2020
Co-Authored-By: Pierre Krieger <pierre.krieger1708@gmail.com>
|
Thanks for the quick review. I will leave this open for another day in case anyone out there depends on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Network::poll_broadcastfunction has not proven to be useful. Thiscommit removes the mechanism all the way down to the connection manager.
With
poll_broadcastgone there is no mechanism left to send commandsto pending connections. Thereby command buffering for pending
connections is not needed anymore and is thus removed in this commit as
well.
Fixes #1465.
Replaces #1501.