protocols/kad/behaviour: Use HashSet to deduplicate GetProviders #1528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that the order of `PeerId`s within the `GetProvidersOk.providers` set is irrelevant but duplication is at best confusing this commit makes use of a `HashSet` instead of a `Vec` to return unique `PeerId`s only.
romanb
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that the order of
PeerIds within theGetProvidersOk.providersset is irrelevant but duplication is at best confusing this commit makes
use of a
HashSetinstead of aVecto return uniquePeerIds only.Fixes #1507.