replace Vec with FuturesUnordered #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
requested changes
Apr 9, 2018
| } | ||
| Ok(Async::Ready(None)) => {} | ||
| Err(err) => { | ||
| warn!(target: "libp2p-swarm", "Error in listener: {:?}", err); |
There was a problem hiding this comment.
I this this warning should be kept.
| self.listeners_upgrade.push(upgrade); | ||
| } | ||
| Err(err) => { | ||
| debug!(target: "libp2p-swarm", "Error in listener upgrade: {:?}", err); |
| self.dialers.push(dialer); | ||
| } | ||
| Err(err) => { | ||
| debug!(target: "libp2p-swarm", "Error in dialer upgrade: {:?}", err); |
There was a problem hiding this comment.
@tomaka added err log
swarm/src/swarm.rs
Outdated
| } | ||
| Ok(Async::NotReady) => self.to_process.push(to_process), | ||
| Err(err) => { | ||
| debug!(target: "libp2p-swarm", "Error in processing: {:?}", err); |
tomaka
approved these changes
Apr 16, 2018
|
Thanks |
quake
added a commit
to quake/rust-libp2p
that referenced
this pull request
Apr 20, 2018
twittner
added a commit
to twittner/rust-libp2p
that referenced
this pull request
May 2, 2018
This reverts commit 9674744.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.