Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't leak default features #1986

Merged
merged 1 commit into from Mar 3, 2021
Merged

Don't leak default features #1986

merged 1 commit into from Mar 3, 2021

Conversation

quininer
Copy link
Contributor

@quininer quininer commented Mar 3, 2021

If you directly rely on libp2p crate, you cannot turn off some default-features even if you use default-features = false.

romanb
romanb approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@romanb romanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@romanb romanb merged commit 6eb8b65 into libp2p:master Mar 3, 2021
@quininer quininer deleted the patch-2 branch March 3, 2021 10:13
@name1e5s name1e5s mentioned this pull request Oct 28, 2021
Closed
@quininer quininer mentioned this pull request Mar 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanb romanb romanb approved these changes

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@quininer @romanb @mxinden