Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with secp256k1 disabled #2057

Merged
merged 2 commits into from
Apr 26, 2021
Merged

Fix build with secp256k1 disabled #2057

merged 2 commits into from
Apr 26, 2021

Conversation

vorot93
Copy link
Contributor

@vorot93 vorot93 commented Apr 24, 2021

No description provided.

Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me, thanks for the patch. @vorot93 if you could include the diff below, I can cut a patch release of libp2p-core right away.

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 81c74f28..62705acc 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -41,6 +41,11 @@
 
 # `libp2p` facade crate
 
+## Version 0.37.2 [unreleased]
+
+- Update individual crates.
+    - `libp2p-core`
+
 ## Version 0.37.1 [2021-04-14]
 
 - Update individual crates.
@@ -61,7 +66,7 @@
     - `libp2p-swarm`
     - `libp2p-wasm-ext`
     - `libp2p-yamux`
-    
+
 - Drop support for `wasm32-unknown-unknown` in favor of
   `wasm32-unknown-emscripten` and `wasm32-wasi` [PR
   2038](https://github.com/libp2p/rust-libp2p/pull/2038).
diff --git a/Cargo.toml b/Cargo.toml
index 2928d5a0..acb1ab8d 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -2,7 +2,7 @@
 name = "libp2p"
 edition = "2018"
 description = "Peer-to-peer networking library"
-version = "0.37.1"
+version = "0.37.2"
 authors = ["Parity Technologies <admin@parity.io>"]
 license = "MIT"
 repository = "https://github.com/libp2p/rust-libp2p"
@@ -64,7 +64,7 @@ atomic = "0.5.0"
 bytes = "1"
 futures = "0.3.1"
 lazy_static = "1.2"
-libp2p-core = { version = "0.28.2", path = "core",  default-features = false }
+libp2p-core = { version = "0.28.3", path = "core",  default-features = false }
 libp2p-floodsub = { version = "0.29.0", path = "protocols/floodsub", optional = true }
 libp2p-gossipsub = { version = "0.30.0", path = "./protocols/gossipsub", optional = true }
 libp2p-identify = { version = "0.29.0", path = "protocols/identify", optional = true }
diff --git a/core/CHANGELOG.md b/core/CHANGELOG.md
index c469754b..d4f3a99f 100644
--- a/core/CHANGELOG.md
+++ b/core/CHANGELOG.md
@@ -1,3 +1,7 @@
+# 0.28.3 [2021-04-26]
+
+- Fix build with secp256k1 disabled [PR 2057](https://github.com/libp2p/rust-libp2p/pull/2057].
+
 # 0.28.2 [2021-04-13]
 
 - Update dependencies.
diff --git a/core/Cargo.toml b/core/Cargo.toml
index 6b910042..1836d90b 100644
--- a/core/Cargo.toml
+++ b/core/Cargo.toml
@@ -2,7 +2,7 @@
 name = "libp2p-core"
 edition = "2018"
 description = "Core traits and structs of libp2p"
-version = "0.28.2"
+version = "0.28.3"
 authors = ["Parity Technologies <admin@parity.io>"]
 license = "MIT"
 repository = "https://github.com/libp2p/rust-libp2p"

@vorot93
Copy link
Contributor Author

vorot93 commented Apr 26, 2021

@mxinden done

Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@mxinden mxinden merged commit 5ee003b into libp2p:master Apr 26, 2021
@mxinden
Copy link
Member

mxinden commented Apr 26, 2021

Tagged and published.

@vorot93 vorot93 deleted the fix-no-secp256k1-build branch April 26, 2021 15:00
AgeManning pushed a commit to sigp/rust-libp2p that referenced this pull request May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants