core/: Remove TInEvent and TOutEvent #2183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes the `Swarm` type alias, renaming `ExpandedSwarm` to `Swarm`. - Remove `TInEvent`, `TOutEvent` and `THandler` trait parameters on `Swarm`, instead deriving them through `TBehaviour`. Move derive logic to separate type aliases. - Simplify trait bounds on `Swarm` main `impl` and `Stream` `impl`.
TInEvent and TOutEvent are implied through THandler and thus superflucious. Both are removed in favor of a derivation through THandler.
|
@thomaseizinger given your review on #2182, could you take a look at this patch as well? |
Merged
protocols/relay/CHANGELOG.md
Outdated
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| - Update dependencies. | |||
|
|
|||
| - Implement `Debug` for `RelayHandlerEvent` and `RealyHandlerIn`. See [PR 2183]. | |||
There was a problem hiding this comment.
Minor typo RealyHandlerIn.
Suggested change
| - Implement `Debug` for `RelayHandlerEvent` and `RealyHandlerIn`. See [PR 2183]. | |
| - Implement `Debug` for `RelayHandlerEvent` and `RelayHandlerIn`. See [PR 2183]. |
There was a problem hiding this comment.
Thanks. Fixed in 6435bd7.
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| - Update dependencies. | |||
|
|
|||
| - Implement `Debug` for `RequestResponseCodec` and `RequestProtocol`. See [PR 2183]. | |||
There was a problem hiding this comment.
Is that accurate? The Debug impl of RequestProtocol already existed, just now it is hand-rolled.
And I can't see a Debug impl for RequestResponseCodec itself.
Is this a leftover from an earlier iteration?
There was a problem hiding this comment.
Good point. Addressed in d78576c.
swarm/src/protocols_handler.rs
Outdated
| @@ -101,11 +101,11 @@ pub use select::{IntoProtocolsHandlerSelect, ProtocolsHandlerSelect}; | |||
| /// continue reading data until the remote closes its side of the connection. | |||
| pub trait ProtocolsHandler: Send + 'static { | |||
| /// Custom event that can be received from the outside. | |||
| type InEvent: Send + 'static; | |||
| type InEvent: Debug + Send + 'static; | |||
There was a problem hiding this comment.
If you would reference these as fmt::Debug, the imports would be slightly cleaner.
There was a problem hiding this comment.
I am fine either way. Applied suggestion in 4576356.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TInEvent and TOutEvent are implied through THandler and thus
superflucious. Both are removed in favor of a derivation through
THandler.