Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protocols/kad: populate the key field to fix go-libp2p interop #2309

Merged
merged 4 commits into from Oct 30, 2021
Merged

protocols/kad: populate the key field to fix go-libp2p interop #2309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0c8a1e3
Populate the key field. This fixes go-libp2p interop
pradt2 Oct 24, 2021
716bd0f
Merge branch 'master' into fix-missing-key
mxinden Oct 30, 2021
d5464dc
Merge branch 'master' into fix-missing-key
pradt2 Oct 30, 2021
c1cb8fb
Add CHANGELOG.md entry
pradt2 Oct 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions protocols/kad/CHANGELOG.md
View file
Open in desktop
Expand Up @@ -6,8 +6,11 @@
`InboundPutRecordRequest` into `InboundRequest::PutRecord` and `InboundAddProviderRequest` into
`InboundRequest::AddProvider` (see [PR 2297]).

- Populate the `key` field when converting `KadRequestMsg::PutValue` to `proto::Message` (see [PR 2309]).

[PR 2245]: https://github.com/libp2p/rust-libp2p/pull/2245
[PR 2297]: https://github.com/libp2p/rust-libp2p/pull/2297
[PR 2309]: https://github.com/libp2p/rust-libp2p/pull/2309

# 0.32.0-rc.2 [2021-10-15]

Expand Down
1 change: 1 addition & 0 deletions protocols/kad/src/protocol.rs
View file
Open in desktop
Expand Up @@ -378,6 +378,7 @@ fn req_msg_to_proto(kad_msg: KadRequestMsg) -> proto::Message {
},
KadRequestMsg::PutValue { record } => proto::Message {
r#type: proto::message::MessageType::PutValue as i32,
key: record.key.to_vec(),
record: Some(record_to_proto(record)),
..proto::Message::default()
},
Expand Down