Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add performance metrics to gossipsub #2346

Merged
merged 14 commits into from
Dec 21, 2021

Conversation

divagant-martian
Copy link
Contributor

@divagant-martian divagant-martian commented Nov 16, 2021

Add two metrics that help analyze if certain configurations/network are performing as expected.

@AgeManning AgeManning force-pushed the gossipsub-network-performance-metrics branch from 258ad2d to d3165fc Compare December 13, 2021 08:10
@AgeManning
Copy link
Contributor

I think this is ready for review and another handy one to get down before some more gossipsub updates.

Will give a basis for future metrics should we need them.

Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

As a side note, I have created a Grafana dashboard for metrics exposed for libp2p-identify, libp2p-ping and libp2p-kad. Maybe we can join efforts and include the Gossipsub metrics as well.

@mxinden
Copy link
Member

mxinden commented Dec 21, 2021

Mind resolving the merge conflicts now that #2327 is merged? Other than that, this is good to go from my side.

@AgeManning
Copy link
Contributor

Yep. I've got a bunch related to the new metrics (some are lighthouse-specific) but we should be able to rip out the gossipsub ones and combine them.

Do you have a repo somewhere for your dashboards. My current one is here: https://github.com/sigp/lighthouse-metrics/blob/network/dashboards/LighthouseNetwork.json

@AgeManning AgeManning merged commit 17861d9 into libp2p:master Dec 21, 2021
@AgeManning AgeManning deleted the gossipsub-network-performance-metrics branch February 15, 2022 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants