Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: Add support for ECDSA identities #2352

Merged
merged 6 commits into from
Nov 30, 2021
Merged

core: Add support for ECDSA identities #2352

merged 6 commits into from
Nov 30, 2021

Conversation

davxy
Copy link
Contributor

@davxy davxy commented Nov 21, 2021

@thomaseizinger thomaseizinger changed the title Ecdsa identity core: Add support for ECDSA identities Nov 24, 2021
mxinden
mxinden approved these changes Nov 28, 2021
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @davxy for the pull request.

This looks good to me, though I don't think I should be the only reviewer on a crypto focused pull request.

@dignifiedquire or @burdges do you have opinions on p256 vs ring?

@dignifiedquire
Copy link
Member

@tarcieri should be able to give a better comparison than me.

dignifiedquire
dignifiedquire reviewed Nov 28, 2021
View reviewed changes
Copy link
Member

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implementation from a crypto standpoint looks good to me

thomaseizinger
thomaseizinger reviewed Nov 28, 2021
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Some comments / discussion points.

core/src/identity/ecdsa.rs Show resolved Hide resolved
core/src/identity/ecdsa.rs Show resolved Hide resolved
core/src/identity/ecdsa.rs Show resolved Hide resolved
core/src/identity/ecdsa.rs Outdated Show resolved Hide resolved
@davxy
Fix ECDSA ASN.1 PublicKey serialization
a821bfb 
Furthermore SecretKey can now be serialized/deserialized to/from a byte
vector.
thomaseizinger
thomaseizinger approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

mxinden
mxinden approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davxy for the contribution.

Also tested with https://github.com/libp2p/rust-libp2p/blob/master/examples/ipfs-kad.rs using ECDSA identity.

@mxinden mxinden merged commit 245b056 into libp2p:master Nov 30, 2021
@mxinden
Copy link
Member

mxinden commented Nov 30, 2021

Also thanks to @thomaseizinger and @dignifiedquire for the input!

@davxy davxy deleted the ecdsa_identity branch December 20, 2021 10:11
@davxy davxy mentioned this pull request Nov 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dignifiedquire dignifiedquire dignifiedquire left review comments

@thomaseizinger thomaseizinger thomaseizinger approved these changes

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ECDSA public key format
4 participants
@davxy @dignifiedquire @mxinden @thomaseizinger