Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Replace _serde with dep:serde in Cargo.toml #2868

Merged
merged 5 commits into from
Sep 8, 2022

Conversation

GamePad64
Copy link
Contributor

Remove extern crate serde everywhere else.

Description

New Cargo.toml dep: syntax removes the need of renaming serde to _serde.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am in favor of this. @thomaseizinger is more knowledgeable when it comes to cargo features. @thomaseizinger any objections?

@GamePad64 GamePad64 marked this pull request as ready for review September 5, 2022 06:46
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections, on the contrary. This is a nice simplification!

@thomaseizinger
Copy link
Contributor

I think technically, this is a breaking change because we have previously provided a _serde feature. I'd ignore that though to be honest :)

@thomaseizinger
Copy link
Contributor

Thank you @GamePad64 !

@thomaseizinger thomaseizinger merged commit c650dc1 into libp2p:master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants